Skip to content

CheckoutSessions — top level Setup Future Usage#6292

Open
gbirch-stripe wants to merge 6 commits intomasterfrom
gbirch/cs-pr2-top-level-sfu
Open

CheckoutSessions — top level Setup Future Usage#6292
gbirch-stripe wants to merge 6 commits intomasterfrom
gbirch/cs-pr2-top-level-sfu

Conversation

@gbirch-stripe
Copy link
Copy Markdown
Collaborator

Summary

Implement top level SFU. PMO SFU in subsequent PR

Motivation

https://docs.google.com/document/d/1CWglcOHR6I8cOWKjztPfnhnVG8axucpv-j5cWIoey7E/edit?pli=1&tab=t.g4karprubz63#heading=h.qr0ujyg56e8u

Testing

  • unit tests
  • API mock tests
  • payment sheet form factory tests

Changelog

@gbirch-stripe gbirch-stripe requested review from a team as code owners April 2, 2026 21:59
Comment on lines +468 to +471
func setupFutureUsage(for paymentMethodType: STPPaymentMethodType) -> String? {
_ = paymentMethodType
return setupFutureUsage
}
Copy link
Copy Markdown
Collaborator Author

@gbirch-stripe gbirch-stripe Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PMO SFU logic will go here

@gbirch-stripe gbirch-stripe marked this pull request as draft April 3, 2026 00:29
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

⚠️ Public API changes detected:

StripeConnect

SPI API

-@_exported @_spi(DashboardOnly) @_spi(STP) import StripeCore
+@_exported @_spi(STP) @_spi(DashboardOnly) import StripeCore

If you are adding a new public API consider the following:

  • Do these APIs need to be public or can they be protected with @_spi(STP)?
  • If these APIs need to be public, assess whether they require an API review.

If you are modifying or removing a public API:

  • Does this require a breaking version change?
  • Do these changes require API review?

If you confirm these APIs need to be added/updated and have undergone necessary review, add the label modifies public API to this PR to acknowledge the interface change.
Additionally, if you modified or removed an existing API, ensure you update the changelog to reflect the necessary version bump for your changes. Regular public API changes require a MAJOR version bump, and SPI API changes (other than @_spi(STP)-only declarations) require a MINOR or MAJOR version bump.

ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with master.

@gbirch-stripe
Copy link
Copy Markdown
Collaborator Author

verify public interface is acting up 😞 . verified that no public api changes are being made

@gbirch-stripe gbirch-stripe marked this pull request as ready for review April 3, 2026 22:26
Copy link
Copy Markdown
Collaborator

@porter-stripe porter-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good one question

XCTAssertFalse(session.merchantWillSavePaymentMethod(.card))
}

func testMerchantWillSavePaymentMethod_paymentModeWithTopLevelSetupFutureUsage() {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth adding a test for none setup_future_usage value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants